Pins API #2367
Open
Pins API #2367
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
approved these changes
Jan 19, 2026
Comment on lines
+10
to
+12
| Current.user.pins.includes(:card).ordered | ||
| else | ||
| Current.user.pins.includes(:card).ordered.limit(20) |
Contributor
There was a problem hiding this comment.
How about moving Current.user.pins.includes(:card).ordered to a variable so it isn't repeated, then conditionally limiting for web requests? This endpoint isn't paginated. Should we limit to 100 like for unread notifications to be safe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes pins API endpoints (pin/unpin and pinned cards list).
Pin
POST
/:account_slug/cards/:card_number/pinReturns: 204 No Content
Unpin
DELETE
/:account_slug/cards/:card_number/pinReturns: 204 No Content
Pinned cards list
GET
/my/pinsReturns: an array of card objects (same shape as other card JSON responses).